1994 Honda CB250 Nighthawk wiring diagram - 1994 Honda CB 250 Nighthawk

Question edited for full 'year make model'.
Question moved from Cars and Trucks to correct category.

Well considering the parts you did change, did you check the starter button was passing power? The contacts inside can get worn out. and follow that wire through its various connector blocks. They can corrode. When I got bikes, I took the connectors apart and pushed Vaseline into the female side of the connector. Saves problems down the line.

If that checks out, it is likely to be a faulty new solenoid. You can check it with a multimeter. It is basically an electronic switch that uses low amp power to operate and electronic solenoid to slap 2 contacts together carrying high amperage power to the starter contacts. If you remove the battery and the starter and connect the two and it doesn't turn, then your new starter is faulty.

https://www.google.com/search?q=1994+honda+cb250+nighthawk+starter+not+engaging

..